Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting only select message members #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

authaldo
Copy link

Hey,

first of all thanks for this useful library!

In our use-case we discovered the caveat that converting rather large messages into their corresponding YAML format can take a considerable amount of time. Since we've been only interested in a few selected members of the messages (mainly 'header' information describing the detailed structure of large data blocks), we added a small utility function for converting those message members into their corresponding YAML-format.

@christophebedard
Copy link
Member

christophebedard commented Sep 1, 2023

I'm not a maintainer, but this sounds like a useful feature. It would probably be good if you could add some tests for it, and sign-off your commit(s) (git commit --amend -s).

Signed-off-by: Dominik Authaler <dominik.authaler@uni-ulm.de>
Signed-off-by: Dominik Authaler <dominik.authaler@uni-ulm.de>
Signed-off-by: Dominik Authaler <dominik.authaler@uni-ulm.de>
Signed-off-by: Dominik Authaler <dominik.authaler@uni-ulm.de>
@authaldo authaldo force-pushed the feat_selected_member_deserialization branch from 1d1ab26 to 2421d99 Compare September 3, 2023 16:49
@authaldo
Copy link
Author

authaldo commented Sep 3, 2023

Done, unfortunately I am not even able to request a review from someone. I am not sure whether this repository is still maintained, given the fact that your two pull requests are open for over a year now and didn't receive any kind of response.

@christophebedard
Copy link
Member

Thanks for adding the test!

Yeah, I think this repository was more of an experiment/proof-of-concept. I'll ask around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants