Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci.yaml #96

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Update ci.yaml #96

merged 2 commits into from
Dec 3, 2024

Conversation

mosfet80
Copy link
Contributor

fix node.js <20 deprecation

@mosfet80
Update ci.yaml
cb26174 
fix node.js <20 deprecation
@mosfet80 mosfet80 requested a review from wjwwood as a code owner November 15, 2024 15:42
clalancette
clalancette requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are making changes here, can you please remove the Python 3.6 and 3.7 tests from the matrix? That should allow CI to succeed here.

@cottsay
Copy link
Member

cottsay commented Dec 2, 2024

While we are making changes here, can you please remove the Python 3.6 and 3.7 tests from the matrix? That should allow CI to succeed here.

Looks like that's addressed in #97.

@clalancette clalancette merged commit 33e1c6a into osrf:master Dec 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mosfet80 @cottsay @clalancette