Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is changing the nvidia snippet to be conditioned on 16.04 vs 18.04.
Following behaviors from:
vs
Currently it's conditioned on the host OS, however because the snippet is done in the image I think it would be better to have it conditioned on the image's OS.
I'd originally thought that it was coupled to the host OS as you need the same nvidia drivers as the host. And it worked for 16.04 host and an 18.04 image using the 16.04 injection. However when using the 18.04 host it broke in #14.
@ruffsl can you verify that this works for you? And we can figure out how the parameterization should be done?