Fix setting of TTL on a nil connection in updateNeighbor #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
|
thanks! |
|
Thanks for merging @fujita ! We would need this fix in this Cilium PR cilium/cilium#25708 - would it be potentially possible to crate a patch release (e.g. |
|
We've not made a patch release. Can you work around on your side until the next minor version? |
understood, we will stay on an unreleased version in the meantime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced by my previous PR: #2661
Avoids attempt to set TTL on a nil connection in
updateNeighbor.This can happen e.g. if
UpdatePeercomes very quickly afterAddPeerand the connection is not yet created.