cmd/gobgp: Fix evpn parsing #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests to validate parsing of all EVPN-related configuration. Examples taken from docs/sources/evpn.md.
esi-label follows the format: [esi-label <esi-label> [single-active | all-active]] extractReserved() splits by spaces, returning a list for esi-label, hence failing the type check. Change its parameter value type to paramList to be able to accomodate cases such as "... esi-label 400 single-active".
default-gateway not being declared a reserved keyword led to evpn macadv commands ending as "encap vxlan default-gateway" to fail parsing. In that case, default-gateway was bundled with the previous argument. To fix that, set default-gateway as a reserved keyword of paramFlag type. While there, change the way we detect its existence later on, given that it now exists in our reserved map m, if set.
|
hmm, seems like a transient failure between stopping the server and writing to it - I can't reproduce it locally. Looking at the code, it is definitely unrelated to this PR's changes (happens in pkg/bgp/server_test.go, which doesn't use anything out of |
|
Thanks. Surely, unrelated to this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
docs/source/evpn.mdfor each.esi-labelwith optional arguments correctly.default-gatewayis set