Fix SRv6 prefix SID unmarshalling #2679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During SRv6 prefix SID unmarshalling, wrong Path Attribute length was applied (4B instead of 3B). This was causing a 1 byte difference in PA length after marshalling & unmarshalling. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
rastislavs
force-pushed
the
prefix-sid-fixes
branch
from
eefb0dc
to
dce682a
Compare
|
pushed, thanks. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During SRv6 prefix SID unmarshalling, wrong Path Attribute length was applied (
4B instead of3B). This was causing a 1 byte difference in PathAttribute length after marshalling & unmarshalling.Screenshot from the
TestFullCyclePrefixSIDunit test shows the difference in PathAttribute Length (38vs37) before the fix (now asserted in the unit test):