-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only wait for GR End of RIB for the received address family #2761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, graceful restart waits for the EoR message for all address families "enabled" for the peer, but it should only wait for "received" address families (the address families the peer is capable of handling). Fixes: osrg#2524 Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
2 tasks
Great, thanks! |
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Feb 15, 2024
To pull-in the upstream change (osrg/gobgp#2761) to fix cilium#30367. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Feb 15, 2024
To pull-in the upstream change (osrg/gobgp#2761) to fix cilium#30367. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Feb 15, 2024
To pull-in the upstream change (osrg/gobgp#2761) to fix cilium#30367. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Feb 15, 2024
To pull-in the upstream change (osrg/gobgp#2761) to fix cilium#30367. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Feb 15, 2024
To pull-in the upstream change (osrg/gobgp#2761) to fix cilium#30367. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Feb 16, 2024
To pull-in the upstream change (osrg/gobgp#2761) to fix cilium#30367. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Feb 16, 2024
To pull-in the upstream change (osrg/gobgp#2761) to fix #30367. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
youngnick
pushed a commit
to cilium/cilium
that referenced
this pull request
Feb 19, 2024
To pull-in the upstream change (osrg/gobgp#2761) to fix #30367. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, graceful restart waits for the EoR message for all address families "enabled" for the peer, but it should only wait for "received" address families (the address families the peer is capable of handling).
Fixes: #2524