Fix accepted/rejected adj-in commands #2823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
7e5eb10 wasn't merged? What do you mean? |
|
7e5eb10 contains only server-side changes. This PR contains CLI support for it. |
|
@fujita gentle ping |
|
I don't understand the situation. The server-side code isn't merged. Why we need to merge this pull request to add CLI support for that? |
|
Ugh, sorry for the confusion. The correct commit is bec61c4 I guess - the one that adds a simple This PR sets said flag in the |
|
Pushed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original logic for accepted/rejected commands was removed in 2dbca9e when IN policies were deprecated.
Then 7e5eb10 added support for server-side filtering based on IMPORT polcies, but CLI support wasn't added. Repurposing accepted/rejected commands for this.