Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accepted/rejected adj-in commands #2823

Closed
wants to merge 1 commit into from

Conversation

myaut
Copy link

@myaut myaut commented Jul 19, 2024

Original logic for accepted/rejected commands was removed in 2dbca9e when IN policies were deprecated.

Then 7e5eb10 added support for server-side filtering based on IMPORT polcies, but CLI support wasn't added. Repurposing accepted/rejected commands for this.

Original logic for accepted/rejected commands was removed
in 2dbca9e when IN policies
were deprecated.

Then 7e5eb10 added support
for server-side filtering based on IMPORT polcies, but
CLI support wasn't added. Repurposing accepted/rejected
commands for this.
@fujita
Copy link
Member

fujita commented Jul 26, 2024

7e5eb10 wasn't merged? What do you mean?

@myaut
Copy link
Author

myaut commented Jul 26, 2024

7e5eb10 contains only server-side changes. This PR contains CLI support for it.

@bayrinat
Copy link
Contributor

@fujita gentle ping

@fujita
Copy link
Member

fujita commented Sep 13, 2024

I don't understand the situation. The server-side code isn't merged. Why we need to merge this pull request to add CLI support for that?

@myaut
Copy link
Author

myaut commented Sep 15, 2024

Ugh, sorry for the confusion. The correct commit is bec61c4 I guess - the one that adds a simple EnableFiltered to the server.

This PR sets said flag in the accepted/rejected commands.

@fujita
Copy link
Member

fujita commented Sep 26, 2024

Pushed, thanks!

@fujita fujita closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants