Do not preserve MPReachNLRI attribute the way we receive it from wire #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 25, 2024 12:28
Right now table.ProcessMessage() rebuilds attribute list, but preserves
MPReachNLRI attribute as is. This causes trouble if GoBGP has a neighbor
that merges multiple NLRIs having same nexthop in a single BGP update
message and if GoBGP has a watcher. Thus watcher receives up to n^2
nlris (n paths each containing n NLRIs) causing enormous memory
consumption (since serialization/deserialization removes deduplication).
Since having all NLRIs in each path is useless in most cases, the
behavior is changed so only relevant NLRI is present in BGP path, but
for backward compatibility old behavior can be reenabled using config
option:
bgp-update-processing:
config:
preserve-nlris: false
In our tests memory consumption of such watcher had reduced from 19 Gb
to 2Gb (with around 300K routes in RIB).
myaut
commented
Dec 25, 2024
| @@ -3175,9 +3215,6 @@ type NeighborConfig struct { | |||
| // original -> bgp:peer-group | |||
| // The peer-group with which this neighbor is associated. | |||
| PeerGroup string `mapstructure:"peer-group" json:"peer-group,omitempty"` | |||
| // original -> gobgp:send-software-version | |||
| // gobgp:send-software-version's original type is boolean. | |||
| SendSoftwareVersion bool `mapstructure:"send-software-version" json:"send-software-version,omitempty"` | |||
There was a problem hiding this comment.
Honestly, I do not know why this didn't surface up earlier.
neighbor-interface is defined at line 919 https://github.com/osrg/gobgp/blob/master/tools/pyang_plugins/gobgp.yang#L919
send-software-version at 1010: https://github.com/osrg/gobgp/blob/master/tools/pyang_plugins/gobgp.yang#L1010
It is logical that it goes after it.
Changing order of field broke test, though, so I fixed overrideConfig() in a separate commit
|
I can't recall why but we preserve that attribute for bmp/mrt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
table.ProcessMessage()rebuilds attribute list, but preservesMPReachNLRI attribute as is. This causes trouble if GoBGP has a neighbor
that merges multiple NLRIs having same nexthop in a single BGP update
message and if GoBGP has a watcher. Thus watcher receives up to n^2
nlris (n paths each containing n NLRIs) causing enormous memory
consumption (since serialization/deserialization removes deduplication).
Since having all NLRIs in each path is useless in most cases, the
behavior is changed so only relevant NLRI is present in BGP path, but
for backward compatibility old behavior can be reenabled using config
option:
In our tests memory consumption of such watcher had reduced from 19 Gb
to 2Gb (with around 300K routes in RIB).