Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ShadcnUI's OTP input element for our auth flow #33

Closed
KMKoushik opened this issue Mar 27, 2024 · 5 comments
Closed

Use ShadcnUI's OTP input element for our auth flow #33

KMKoushik opened this issue Mar 27, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@KMKoushik
Copy link
Member

https://ui.shadcn.com/docs/components/input-otp

@KMKoushik KMKoushik added the enhancement New feature or request label Mar 27, 2024
@anantraghuvanshi
Copy link
Contributor

Since we receive 5 characters in the OTP, I think the option we could go for be :
image
or
image
I would like to hear you on this @KMKoushik

@KMKoushik
Copy link
Member Author

Since we receive 5 characters in the OTP, I think the option we could go for be :

I would like to hear you on this @KMKoushik

That sounds good!

@anantraghuvanshi
Copy link
Contributor

Since, we are modifying this page, what I was thinking should be updated is the text "
We have sent an email with the OTP. Please check your inbox" where the plain email could be something like testXXXX@XXXil.com. Would that be okay @KMKoushik ?

@KMKoushik
Copy link
Member Author

Since, we are modifying this page, what I was thinking should be updated is the text " We have sent an email with the OTP. Please check your inbox" where the plain email could be something like testXXXX@XXXil.com. Would that be okay @KMKoushik ?

I also don't mind putting the entire email!

@anantraghuvanshi
Copy link
Contributor

anantraghuvanshi commented Mar 30, 2024

#38 fixes this. Kindly review @KMKoushik

KMKoushik pushed a commit that referenced this issue Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants