Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextauth internal url #153

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

batizisanya
Copy link
Contributor

Add option to set NEXTAUTH_URL_INTERNAL for nextauth.
It's useful in environments when the server doesn't have access to the canonical URL of the site. (NEXTAUTH_URL)

Copy link
Member

@KMKoushik KMKoushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add this compose file?

@batizisanya
Copy link
Contributor Author

can you also add this compose file?

In general, I don't think it's necessary to add the NEXTAUTH_URL_INTERNAL variable to the docker compose file, because that would just lead to misunderstandings by having to set the same url twice. If I add this and the user forget to edit, then the authentication will not work.

For those users who are in the rare situation that they need to use this setting, maybe I would prefer to provide guidance on this in the documentation, but I'm open to your opinion on this.

@KMKoushik KMKoushik self-requested a review December 13, 2024 20:12
Copy link
Member

@KMKoushik KMKoushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KMKoushik KMKoushik merged commit 5ff2edb into oss-apps:main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants