Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue filter field behaves strangely #109

Closed
sschuberth opened this issue Apr 23, 2023 · 1 comment · Fixed by #113
Closed

Issue filter field behaves strangely #109

sschuberth opened this issue Apr 23, 2023 · 1 comment · Fixed by #113
Labels
bug Something isn't working

Comments

@sschuberth
Copy link
Member

sschuberth commented Apr 23, 2023

When looking at a scan with ScanCode timeout issues, and trying to type the word "timeout" into the "Filter" field on the "Issues" tab, some thing strange happens: I seems that depending on how fast you type / how fast the list of issues is filtered on the fly, the cursor sometimes jumps back into the typed characters, resulting in garbled text when continuing to type.

@sschuberth sschuberth added the bug Something isn't working label Apr 23, 2023
@sschuberth
Copy link
Member Author

Aside from that, to cursor is hardly visible. We should probably give it a more contrasting color, like white.

mnonnenmacher added a commit that referenced this issue Apr 30, 2023
If the text of a `TextField` is updated from a flow, this can lead to a
jumping cursor and swallowed characters [1]. For a discussion of the
issue see [2].

Fix this by introducing a local mutable state for the text value.

Fixes #109.

[1]: JetBrains/compose-multiplatform#3089
[2]: https://medium.com/androiddevelopers/effective-state-management-for-textfield-in-compose-d6e5b070fbe5

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@gmail.com>
mnonnenmacher added a commit that referenced this issue Apr 30, 2023
If the text of a `TextField` is updated from a flow, this can lead to a
jumping cursor and swallowed characters [1]. For a discussion of the
issue see [2].

Fix this by introducing a local mutable state for the text value as
suggested in [3].

Fixes #109.

[1]: JetBrains/compose-multiplatform#3089
[2]: https://medium.com/androiddevelopers/effective-state-management-for-textfield-in-compose-d6e5b070fbe5
[3]: cashapp/molecule#63 (comment)

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@gmail.com>
mnonnenmacher added a commit that referenced this issue Apr 30, 2023
If the text of a `TextField` is updated from a flow, this can lead to a
jumping cursor and swallowed characters [1]. For a discussion of the
issue see [2].

Fix this by introducing a local mutable state for the text value as
suggested in [3].

Fixes #109.

[1]: JetBrains/compose-multiplatform#3089
[2]: https://medium.com/androiddevelopers/effective-state-management-for-textfield-in-compose-d6e5b070fbe5
[3]: cashapp/molecule#63 (comment)

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant