LicenseInfoResolverTest: Rewrite code to get rid of an extension func…

…tion

SimpleLicenseInfoProvider is only ever used with a List of LicenseInfo,
so simply create the map internally to get rid of the private extension
function.

Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>

model/src/test/kotlin/licenses/LicenseInfoResolverTest.kt

@@ -521,7 +521,7 @@ class LicenseInfoResolverTest : WordSpec() {
         copyrightGarbage: Set<String> = emptySet(),
         archiver: FileArchiver = FileArchiver.DEFAULT
     ) = LicenseInfoResolver(
-        data.toProvider(),
+        SimpleLicenseInfoProvider(data),
         CopyrightGarbage(copyrightGarbage.toSortedSet()),
         archiver
     )
@@ -549,13 +549,13 @@ class LicenseInfoResolverTest : WordSpec() {
         )
 }
 
-private class SimpleLicenseInfoProvider(val licenseInfo: Map<Identifier, LicenseInfo>) : LicenseInfoProvider {
+private class SimpleLicenseInfoProvider(licenseInfo: List<LicenseInfo>) : LicenseInfoProvider {
+    private val licenseInfoById = licenseInfo.associateBy { it.id }
+
     override fun get(id: Identifier) =
-        licenseInfo[id] ?: throw IllegalArgumentException("No license info for '${id.toCoordinates()}' available.")
+        licenseInfoById[id] ?: throw IllegalArgumentException("No license info for '${id.toCoordinates()}' available.")
 }
 
-private fun List<LicenseInfo>.toProvider() = SimpleLicenseInfoProvider(associateBy { it.id })
-
 private fun Map<String, List<TextLocation>>.toFindingsSet(): Set<LicenseFinding> =
     flatMap { (license, locations) ->
         locations.map { LicenseFinding(license, it) }