chore(advisor): Remove Jackson annotations from configuration classes

Remove the Jackson annotation from the advice provider configuration classes as the configurations are not used for serialization anymore. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
oss-review-toolkit · Oct 16, 2023 · 7250e66 · 7250e66
1 parent 57bd6ad
commit 7250e66
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 17 deletions.
diff --git a/advisor/src/main/kotlin/advisors/GitHubDefectsConfiguration.kt b/advisor/src/main/kotlin/advisors/GitHubDefectsConfiguration.kt
@@ -19,24 +19,19 @@
 
 package org.ossreviewtoolkit.advisor.advisors
 
-import com.fasterxml.jackson.annotation.JsonInclude
-import com.fasterxml.jackson.annotation.JsonProperty
-
 /**
  * The configuration for the GitHub Defects advisor.
  */
 data class GitHubDefectsConfiguration(
     /**
      * The access token to authenticate against the GitHub GraphQL endpoint.
      */
-    @JsonProperty(access = JsonProperty.Access.WRITE_ONLY)
     val token: String? = null,
 
     /**
      * The URL of the GraphQL endpoint to be accessed by the service. If undefined, default is the endpoint of the
      * official GitHub GraphQL API.
      */
-    @JsonInclude(JsonInclude.Include.NON_DEFAULT)
     val endpointUrl: String? = null,
 
     /**
@@ -59,7 +54,6 @@ data class GitHubDefectsConfiguration(
      * Per default, some of GitHub's default labels are excluded that typically indicate that an issue is not a defect
      * (see https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels#about-default-labels)
      */
-    @JsonInclude(JsonInclude.Include.NON_DEFAULT)
     val labelFilter: List<String> = listOf("!duplicate", "!enhancement", "!invalid", "!question", "*"),
 
     /**

diff --git a/advisor/src/main/kotlin/advisors/NexusIqConfiguration.kt b/advisor/src/main/kotlin/advisors/NexusIqConfiguration.kt
@@ -19,9 +19,6 @@
 
 package org.ossreviewtoolkit.advisor.advisors
 
-import com.fasterxml.jackson.annotation.JsonInclude
-import com.fasterxml.jackson.annotation.JsonProperty
-
 /**
  * The configuration for Nexus IQ as a security vulnerability provider.
  */
@@ -34,7 +31,6 @@ data class NexusIqConfiguration(
     /**
      * A URL to use as a base for browsing vulnerability details. Defaults to the server URL.
      */
-    @JsonInclude(JsonInclude.Include.NON_DEFAULT)
     val browseUrl: String = serverUrl,
 
     /**
@@ -47,6 +43,5 @@ data class NexusIqConfiguration(
      * The password to use for authentication. If not both [username] and [password] are provided, authentication is
      * disabled.
      */
-    @JsonProperty(access = JsonProperty.Access.WRITE_ONLY)
     val password: String? = null
 )
diff --git a/advisor/src/main/kotlin/advisors/OssIndexConfiguration.kt b/advisor/src/main/kotlin/advisors/OssIndexConfiguration.kt
@@ -19,8 +19,6 @@
 
 package org.ossreviewtoolkit.advisor.advisors
 
-import com.fasterxml.jackson.annotation.JsonProperty
-
 /**
  * The configuration for the OSS Index provider.
  */
@@ -41,6 +39,5 @@ data class OssIndexConfiguration(
      * The password to use for authentication. If not both [username] and [password] are provided, authentication is
      * disabled.
      */
-    @JsonProperty(access = JsonProperty.Access.WRITE_ONLY)
     val password: String? = null
 )
diff --git a/advisor/src/main/kotlin/advisors/VulnerableCodeConfiguration.kt b/advisor/src/main/kotlin/advisors/VulnerableCodeConfiguration.kt
@@ -19,8 +19,6 @@
 
 package org.ossreviewtoolkit.advisor.advisors
 
-import com.fasterxml.jackson.annotation.JsonProperty
-
 /**
  * The configuration for VulnerableCode as security vulnerability provider.
  */
@@ -33,6 +31,5 @@ data class VulnerableCodeConfiguration(
     /**
      * The optional API key to use.
      */
-    @JsonProperty(access = JsonProperty.Access.WRITE_ONLY)
     val apiKey: String? = null
 )