test(node): Make the naming of expected result files more consistent

Consistently use `expected-output` as suffix, and align the name of the expected result for skipping scope excludes with `yarn2-project-with-lockfile-skip-excluded-scopes-expected-output.yml`. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
oss-review-toolkit · Sep 24, 2024 · 837d588 · 837d588
1 parent 9198c5b
commit 837d588
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/...hetic/npm-expected-output-no-lockfile.yml → ...hetic/npm-no-lockfile-expected-output.yml b/...hetic/npm-expected-output-no-lockfile.yml → ...hetic/npm-no-lockfile-expected-output.yml
diff --git a/...ic/npm-expected-output-scope-excludes.yml → ...-skip-excluded-scopes-expected-output.yml b/...ic/npm-expected-output-scope-excludes.yml → ...-skip-excluded-scopes-expected-output.yml
diff --git a/...expected-output-project-with-lockfile.yml → ...project-with-lockfile-expected-output.yml b/...expected-output-project-with-lockfile.yml → ...project-with-lockfile-expected-output.yml
diff --git a/plugins/package-managers/node/src/funTest/kotlin/NpmFunTest.kt b/plugins/package-managers/node/src/funTest/kotlin/NpmFunTest.kt
@@ -58,7 +58,9 @@ class NpmFunTest : WordSpec({
 
         "exclude scopes if configured" {
             val definitionFile = getAssetFile("projects/synthetic/npm/shrinkwrap/package.json")
-            val expectedResultFile = getAssetFile("projects/synthetic/npm-expected-output-scope-excludes.yml")
+            val expectedResultFile = getAssetFile(
+                "projects/synthetic/npm-shrinkwrap-skip-excluded-scopes-expected-output.yml"
+            )
 
             val result = create("NPM", excludedScopes = setOf("devDependencies"))
                 .resolveSingleProject(definitionFile, resolveScopes = true)
@@ -84,7 +86,7 @@ class NpmFunTest : WordSpec({
 
         "show an error if no lockfile is present" {
             val definitionFile = getAssetFile("projects/synthetic/npm/no-lockfile/package.json")
-            val expectedResultFile = getAssetFile("projects/synthetic/npm-expected-output-no-lockfile.yml")
+            val expectedResultFile = getAssetFile("projects/synthetic/npm-no-lockfile-expected-output.yml")
 
             val result = create("NPM").resolveSingleProject(definitionFile)
 

diff --git a/plugins/package-managers/node/src/funTest/kotlin/YarnFunTest.kt b/plugins/package-managers/node/src/funTest/kotlin/YarnFunTest.kt
@@ -32,7 +32,7 @@ class YarnFunTest : WordSpec({
     "yarn" should {
         "resolve dependencies correctly" {
             val definitionFile = getAssetFile("projects/synthetic/yarn/project-with-lockfile/package.json")
-            val expectedResultFile = getAssetFile("projects/synthetic/yarn-expected-output-project-with-lockfile.yml")
+            val expectedResultFile = getAssetFile("projects/synthetic/yarn-project-with-lockfile-expected-output.yml")
 
             val result = create("Yarn").resolveSingleProject(definitionFile, resolveScopes = true)