feat(scancode): Try to to get more information on failures

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
oss-review-toolkit · Sep 26, 2024 · cd70325 · cd70325
1 parent 062f517
commit cd70325
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/plugins/scanners/scancode/src/main/kotlin/ScanCode.kt b/plugins/scanners/scancode/src/main/kotlin/ScanCode.kt
@@ -149,6 +149,7 @@ class ScanCode internal constructor(
         return with(process) {
             // Do not throw yet if the process exited with an error as some errors might turn out to be tolerable during
             // parsing.
+            if (isError && stdout.isNotBlank()) logger.debug { stdout }
             if (stderr.isNotBlank()) logger.debug { stderr }
 
             resultFile.readText().also { resultFile.parentFile.safeDeleteRecursively() }

diff --git a/plugins/scanners/scancode/src/test/kotlin/ScanCodeTest.kt b/plugins/scanners/scancode/src/test/kotlin/ScanCodeTest.kt
@@ -102,6 +102,7 @@ class ScanCodeTest : WordSpec({
 
             val process = mockk<ProcessCapture>()
             every { process.isError } returns true
+            every { process.stdout } returns ""
             every { process.stderr } returns "some error"
 
             val scannerSpy = spyk(scanner)