Skip to content

Commit

Permalink
ci(github): Do not build the web-app reporter separately anymore
Browse files Browse the repository at this point in the history
As of [1] the web-app reporter build became much faster. The overhead to
set up a new job now is bigger than the actual build time in most of the
cases / for incremental builds, so include the web-app reporter build
into the regular build again to simplify the setup.

[1]: #7952

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
  • Loading branch information
sschuberth committed Apr 29, 2024
1 parent 8f945e9 commit f51b2a5
Showing 1 changed file with 4 additions and 16 deletions.
20 changes: 4 additions & 16 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,7 @@ jobs:
with:
gradle-home-cache-cleanup: true
- name: Build all classes
run: ./gradlew --scan classes -x :plugins:reporters:web-app-template:yarnBuild
build-web-app-reporter:
needs: build
runs-on: ubuntu-22.04
steps:
- name: Checkout Repository
uses: actions/checkout@v4
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v3
with:
gradle-home-cache-cleanup: true
- name: Build the web-app-reporter
run: ./gradlew --scan :plugins:reporters:web-app-template:yarnBuild
run: ./gradlew --scan classes
codeql-analysis:
needs: build
runs-on: ubuntu-22.04
Expand All @@ -55,7 +43,7 @@ jobs:
with:
gradle-home-cache-cleanup: true
- name: Build all classes
run: ./gradlew -Dorg.gradle.jvmargs=-Xmx1g classes -x :plugins:reporters:web-app-template:yarnBuild
run: ./gradlew -Dorg.gradle.jvmargs=-Xmx1g classes
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
test:
Expand All @@ -69,14 +57,14 @@ jobs:
with:
gradle-home-cache-cleanup: true
- name: Run unit tests
run: ./gradlew --scan test jacocoTestReport -x :plugins:reporters:web-app-template:yarnBuild
run: ./gradlew --scan test jacocoTestReport
- name: Upload code coverage data
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
flags: test
funTest-non-docker:
needs: build-web-app-reporter
needs: build
runs-on: ubuntu-22.04
steps:
- name: Checkout Repository
Expand Down

0 comments on commit f51b2a5

Please sign in to comment.