Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show issues tab in Web App Reporter #6232

Closed
hanna-modica opened this issue Dec 14, 2022 · 0 comments · Fixed by #7171
Closed

Always show issues tab in Web App Reporter #6232

hanna-modica opened this issue Dec 14, 2022 · 0 comments · Fixed by #7171
Labels
enhancement Issues that are considered to be enhancements reporter About the reporter tool

Comments

@hanna-modica
Copy link
Contributor

hanna-modica commented Dec 14, 2022 •
edited
Loading

When all issues are resolved, the issues tab disappears in the Web App Reporter. Unfortunately, this makes it hard to spot an issue, that was "falsely" resolved and is still making problems.

Also, the tab should appear IMO, even if there are no issues, since it is confusing, to have a tab only appear sometimes. If there are no issues, it just should state so, when selecting the tab.
@hanna-modica hanna-modica changed the title Always show issues in Web App Reporter Always show issues tab in Web App Reporter Dec 14, 2022
@sschuberth sschuberth added enhancement Issues that are considered to be enhancements reporter About the reporter tool labels Dec 14, 2022
hanna-modica added a commit to boschglobal/oss-review-toolkit that referenced this issue Jun 21, 2023
@hanna-modica
feat(web-app-reporter): Always show issue tab
70fe3e3 
This allows on one hand the view to be more consistent, by always showing the same tab, and on the other hand allows to check resolved issues, even if there are no open issues left.

resolves oss-review-toolkit#6232
hanna-modica added a commit to boschglobal/oss-review-toolkit that referenced this issue Jun 21, 2023
@hanna-modica
feat(web-app-reporter): Always show issue tab
4f3cd66 
This allows on one hand the view to be more consistent, by always showing the same tab, and on the other hand allows to check resolved issues, even if there are no open issues left.

resolves oss-review-toolkit#6232

Signed-off-by: Hanna Modica <Hanna.Modica@bosch.io>
@hanna-modica hanna-modica mentioned this issue Jun 21, 2023
Merged
hanna-modica added a commit to boschglobal/oss-review-toolkit that referenced this issue Jun 27, 2023
@hanna-modica
feat(web-app-reporter): Always show first three tabs
bf81fbc 
Always shows rule violations, issue and vulnerabilities tab. This allows
on one hand the view to be more consistent, by always showing the same
tab, and on the other hand allows to check resolutions, even if there are
no open violations, issues or vulnerabilities left.

resolves oss-review-toolkit#6232

Signed-off-by: Hanna Modica <Hanna.Modica@bosch.io>
hanna-modica added a commit to boschglobal/oss-review-toolkit that referenced this issue Jun 27, 2023
@hanna-modica
feat(web-app-reporter): Always show first three tabs
3bdc3fa 
Always show the rule violations, issues and vulnerabilities tabs. This
allows on the one hand the view to be more consistent, by always showing
the same tabs, and on the other hand allows to check resolutions, even if
there are no open violations, issues or vulnerabilities left.

resolves oss-review-toolkit#6232

Signed-off-by: Hanna Modica <Hanna.Modica@bosch.io>

resolves oss-review-toolkit#6232

Signed-off-by: Hanna Modica <Hanna.Modica@bosch.io>
hanna-modica added a commit to boschglobal/oss-review-toolkit that referenced this issue Jun 27, 2023
@hanna-modica
feat(web-app-reporter): Always show first three tabs
6238864 
Always show the rule violations, issues and vulnerabilities tabs. This
allows on the one hand the view to be more consistent, by always showing
the same tabs, and on the other hand allows to check resolutions, even if
there are no open violations, issues or vulnerabilities left.

resolves oss-review-toolkit#6232
hanna-modica added a commit to boschglobal/oss-review-toolkit that referenced this issue Jul 3, 2023
@hanna-modica
feat(web-app-reporter): Always show first three tabs
d5b6236 
Always show the rule violations, issues and vulnerabilities tabs. This
allows on the one hand the view to be more consistent, by always showing
the same tabs, and on the other hand allows to check resolutions, even if
there are no open violations, issues or vulnerabilities left.

Resolves oss-review-toolkit#6232

Signed-off-by: Hanna Modica <Hanna.Modica@bosch.io>
mnonnenmacher pushed a commit that referenced this issue Jul 4, 2023
@hanna-modica @mnonnenmacher
feat(web-app-reporter): Always show first three tabs
00c0dcd 
Always show the rule violations, issues and vulnerabilities tabs. This
allows on the one hand the view to be more consistent, by always showing
the same tabs, and on the other hand allows to check resolutions, even if
there are no open violations, issues or vulnerabilities left.

Resolves #6232

Signed-off-by: Hanna Modica <Hanna.Modica@bosch.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issues that are considered to be enhancements reporter About the reporter tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(web-app-reporter): Always show issue tab boschglobal/oss-review-toolkit
2 participants
@sschuberth @hanna-modica