Spdx document model fixes #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of the generated ID must always be that same constant value, see [1]. [1] https://spdx.github.io/spdx-spec/v2-draft/document-creation-information/#63-spdx-identifier-field. Signed-off-by: Frank Viernau <frank.viernau@here.com>
The value must be of the form "$MAJOR.$MINOR", see [1]. [1] https://spdx.github.io/spdx-spec/v2-draft/document-creation-information/#61-spdx-version-field Signed-off-by: Frank Viernau <frank.viernau@here.com>
fviernau
requested review from
mnonnenmacher,
sschuberth and
tsteenbe
as code owners
sschuberth
reviewed
Jul 1, 2020
sschuberth
previously approved these changes
Jul 1, 2020
To clarifiy that the version string must be of the form "$MAJOR.$MINOR". Signed-off-by: Frank Viernau <frank.viernau@here.com>
sschuberth
approved these changes
Jul 1, 2020
swinslow
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the findings from @swinslow:
See also this related discussion: