Flutter: Bootstrap Flutter/Pub/Dart #3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the big size (around 1.7Gb) and rare use it is more optimal to bootstrap Flutter on demand instead of installing it in the Docker container. This commit implements the bootstrapping logic for Flutter (which includes Pub) and removes Flutter from the Docker image and the CI configurations. With this change it is now possible to choose the Flutter version by setting the `FLUTTER_VERSION` environment variable. Co-authored-by: Martin Nonnenmacher <martin.nonnenmacher@here.com> Signed-off-by: zhernovs <ext-andriy.zhernovskyi@here.com>
tsteenbe
reviewed
Apr 2, 2021
| private val flutterCommand = if (Os.isWindows) "flutter.bat" else "flutter" | ||
| private val pubCommand = if (Os.isWindows) "pub.bat" else "pub" | ||
|
|
||
| private val flutterVersion = Os.env["FLUTTER_VERSION"] ?: "v1.12.13+hotfix.9-stable" |
There was a problem hiding this comment.
I see this still uses Flutter v1.12.13 which current stable is 2.0.3 see https://flutter.dev/docs/development/tools/sdk/releases so we should upgrade else scans will likely fail as the Flutter community is using more and more 2.x.
There was a problem hiding this comment.
Yes, the intention of this PR was not to upgrade Flutter, but to implement the bootstrap mechanism without any further changes to keep things as simple as possible. We can do the upgrade as a follow-up.
|
Merging this without waiting for another review as this is just a copy of #3543 which has already been reviewed. |
|
Thanks for handling this @sschuberth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the big size (around 1.7Gb) and rare use it is more optimal to
bootstrap Flutter on demand instead of installing it in the Docker
container.
This commit implements the bootstrapping logic for Flutter (which
includes Pub) and removes Flutter from the Docker image and the CI
configurations.
With this change it is now possible to choose the Flutter version by
setting the
FLUTTER_VERSIONenvironment variable.Co-authored-by: Martin Nonnenmacher martin.nonnenmacher@here.com
Signed-off-by: zhernovs ext-andriy.zhernovskyi@here.com