Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor preparations for the implementation of file checks #5750

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

fviernau
Copy link
Member

@fviernau fviernau commented Sep 7, 2022

This is a split-out of minor probably uncontroversial changes from #5679, to reduce the size of that other PR.

Move `getRepositoryPath()` to `OrtResultExtensions` to enable re-use in
an upcoming change.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Prepare for extending the test case.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@fviernau fviernau requested a review from a team as a code owner September 7, 2022 07:04
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #5750 (b76e8a2) into main (2d7b039) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #5750      +/-   ##
============================================
- Coverage     57.72%   57.69%   -0.03%     
  Complexity     2210     2210              
============================================
  Files           321      321              
  Lines         18954    18954              
  Branches       3678     3679       +1     
============================================
- Hits          10941    10936       -5     
- Misses         6867     6874       +7     
+ Partials       1146     1144       -2     
Flag Coverage Δ
funTest-analyzer-docker 74.49% <ø> (ø)
funTest-non-analyzer 46.21% <0.00%> (ø)
test 27.57% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
model/src/main/kotlin/utils/OrtResultExtensions.kt 0.00% <0.00%> (ø)
...eporters/freemarker/FreemarkerTemplateProcessor.kt 70.91% <ø> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fviernau fviernau enabled auto-merge (rebase) September 7, 2022 07:17
@fviernau fviernau merged commit 0deb564 into main Sep 7, 2022
@fviernau fviernau deleted the file-checks-split-outs branch September 7, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants