Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Copyright statements #6837

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Clean up Copyright statements #6837

merged 3 commits into from
Apr 20, 2023

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

@sschuberth sschuberth requested a review from a team as a code owner April 12, 2023 12:46
@codecov
Copy link

codecov bot commented Apr 12, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (41f16cd) 64.40% compared to head (829b2c0) 64.40%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #6837   +/-   ##
=========================================
  Coverage     64.40%   64.40%           
  Complexity     1945     1945           
=========================================
  Files           322      322           
  Lines         16104    16104           
  Branches       2296     2296           
=========================================
  Hits          10371    10371           
  Misses         4748     4748           
  Partials        985      985
Flag Coverage Δ
funTest-non-docker 45.42% <ø> (ø)
test 32.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

tsteenbe
tsteenbe requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@tsteenbe tsteenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not touch the copyrights statements of third parties as their licenses require us to reproduce their exact copyright statement - ORT project itself has similar requirement in its Apache-2.0 license - https://github.com/oss-review-toolkit/ort/blob/main/LICENSE#L100-L104.

tsteenbe
tsteenbe reviewed Apr 13, 2023
View reviewed changes
.reuse/dep5
Copyright: 2021 The ORT Project Authors (see <https://github.com/oss-review-toolkit/ort/blob/main/NOTICE>)
License: Apache-2.0

Files: integrations/tekton/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Google attribution is already in the NOTICE file but this is the machine readable version so I would not remove it.

@sschuberth
Copy link
Member Author

We can not touch the copyrights statements of third parties as their licenses require us to reproduce their exact copyright statement

Which means we need to e.g. update these lines whenever the Gradle wrapper changes (in a new year), right?

@sschuberth
Copy link
Member Author

I've dropped the last two commits.

@sschuberth sschuberth requested a review from tsteenbe April 13, 2023 07:42
@sschuberth
Copy link
Member Author

I've dropped the last two commits.

@tsteenbe please have another look.

@sschuberth
chore(reuse): Use the generic Copyright statement
f9e848e 
Also use the inception year only, like already done in the source code.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth
chore(reuse): Move third-party Copyrights to the right section
ca620c6 
Also reorder one entry to be sorted alphabetically by file path.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth
chore(reporter-web-app): Use the generic author name and ORT URL
829b2c0 
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth
Copy link
Member Author

I've dropped the last two commits.

@tsteenbe please have another look.

Ping once more @tsteenbe.

@sschuberth
Copy link
Member Author

Merging despite the unrelated ConanFunTest failure.

@sschuberth sschuberth merged commit c260b5c into main Apr 20, 2023
@sschuberth sschuberth deleted the generic-cr-in-dep5 branch April 20, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteenbe tsteenbe tsteenbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sschuberth @tsteenbe