Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use per language container strategy #7447

Conversation

heliocastro
Copy link
Contributor

Ort language components are built now on independent containers. This enables the possibility to create custom tailored containers with only the required language components, reducing final size and improving build process.

Default runtime now contains Python and NodeJs components. Other language components have their own containers built, and can be included on custom images.

@heliocastro heliocastro requested a review from a team as a code owner September 3, 2023 14:42
@heliocastro heliocastro marked this pull request as draft September 3, 2023 14:43
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (481174c) 60.93% compared to head (0f4dc25) 60.93%.

❗ Current head 0f4dc25 differs from pull request most recent head af55a06. Consider uploading reports for the commit af55a06 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7447   +/-   ##
=========================================
  Coverage     60.93%   60.93%           
  Complexity     1969     1969           
=========================================
  Files           338      338           
  Lines         16626    16626           
  Branches       2363     2363           
=========================================
  Hits          10131    10131           
  Misses         5517     5517           
  Partials        978      978           
Flag Coverage Δ
test 36.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heliocastro heliocastro force-pushed the heliocastro/docker_nextgen branch 3 times, most recently from d1bb930 to a86d541 Compare September 3, 2023 16:32
@heliocastro
Copy link
Contributor Author

Close due #7112

@heliocastro heliocastro closed this Sep 3, 2023
@sschuberth
Copy link
Member

Close due #7112

Now both PRs are closed!?

@heliocastro heliocastro reopened this Sep 4, 2023
@heliocastro heliocastro force-pushed the heliocastro/docker_nextgen branch 6 times, most recently from c0099d7 to f2d9bda Compare September 4, 2023 08:52
@heliocastro heliocastro self-assigned this Sep 4, 2023
@heliocastro heliocastro added enhancement Issues that are considered to be enhancements docker About Docker topics labels Sep 4, 2023
@heliocastro heliocastro force-pushed the heliocastro/docker_nextgen branch 8 times, most recently from 644fac3 to 0021326 Compare September 5, 2023 06:40
Ort language components are built now in independent containers.
This enables the possibility to create custom tailored containers with
only the required language components, reducing final size and improving
build process.

Default runtime now contains Python and NodeJs components. Other
language components have their own containers built, and can be
included on custom images.

Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
… base

Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
@heliocastro heliocastro force-pushed the heliocastro/docker_nextgen branch from e01e88b to 0f4dc25 Compare September 7, 2023 07:44
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker About Docker topics enhancement Issues that are considered to be enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants