Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "deps: update graphqlplugin to v7" #7539

Merged

Conversation

MarcelBochtler
Copy link
Member

@MarcelBochtler MarcelBochtler commented Sep 20, 2023

This reverts commit 0dfdaca, because it breaks Java 11 compatibility, see 1.

Trying to build the Docker image using JDK version 11 results in this error with graphql version 7.0:

#12 [build 5/5] RUN --mount=type=cache,target=/tmp/.gradle/     export GRADLE_USER_HOME=/tmp/.gradle/ &&     scripts/export_proxy_certificates.sh /tmp/certificates/ &&     scripts/import_certificates.sh /tmp/certificates/ &&     scripts/set_gradle_proxy.sh &&     ./gradlew --no-daemon --stacktrace -Pversion=968a82e :cli:installDist :helper-cli:startScripts
#12 256.1 
#12 256.1 FAILURE: Build failed with an exception.
#12 256.1 
#12 256.1 * What went wrong:
#12 256.1 A problem occurred configuring project ':clients:github-graphql-client'.
#12 256.1 > Could not resolve all files for configuration ':clients:github-graphql-client:classpath'.
#12 256.1    > Could not resolve com.expediagroup:graphql-kotlin-gradle-plugin:7.0.0.
#12 256.1      Required by:
#12 256.1          project :clients:github-graphql-client > com.expediagroup.graphql:com.expediagroup.graphql.gradle.plugin:7.0.0
#12 256.1       > No matching variant of com.expediagroup:graphql-kotlin-gradle-plugin:7.0.0 was found. The consumer was configured to find a library for use during runtime, compatible with Java 11, packaged as a jar, and its dependencies declared externally, as well as attribute 'org.gradle.plugin.api-version' with value '8.3' but:
#12 256.1           - Variant 'apiElements' capability com.expediagroup:graphql-kotlin-gradle-plugin:7.0.0 declares a library, packaged as a jar, and its dependencies declared externally:
#12 256.1               - Incompatible because this component declares a component for use during compile-time, compatible with Java 17 and the consumer needed a component for use during runtime, compatible with Java 11
#12 256.1               - Other compatible attribute:
#12 256.1                   - Doesn't say anything about org.gradle.plugin.api-version (required '8.3')
#12 256.1           - Variant 'javadocElements' capability com.expediagroup:graphql-kotlin-gradle-plugin:7.0.0 declares a component for use during runtime, and its dependencies declared externally:
#12 256.1               - Incompatible because this component declares documentation and the consumer needed a library
#12 256.1               - Other compatible attributes:
#12 256.1                   - Doesn't say anything about its target Java version (required compatibility with Java 11)
#12 256.1                   - Doesn't say anything about its elements (required them packaged as a jar)
#12 256.1                   - Doesn't say anything about org.gradle.plugin.api-version (required '8.3')
#12 256.1           - Variant 'runtimeElements' capability com.expediagroup:graphql-kotlin-gradle-plugin:7.0.0 declares a library for use during runtime, packaged as a jar, and its dependencies declared externally:
#12 256.1               - Incompatible because this component declares a component, compatible with Java 17 and the consumer needed a component, compatible with Java 11
#12 256.1               - Other compatible attribute:
#12 256.1                   - Doesn't say anything about org.gradle.plugin.api-version (required '8.3')
#12 256.1           - Variant 'sourcesElements' capability com.expediagroup:graphql-kotlin-gradle-plugin:7.0.0 declares a component for use during runtime, and its dependencies declared externally:
#12 256.1               - Incompatible because this component declares documentation and the consumer needed a library
#12 256.1               - Other compatible attributes:
#12 256.1                   - Doesn't say anything about its target Java version (required compatibility with Java 11)
#12 256.1                   - Doesn't say anything about its elements (required them packaged as a jar)
#12 256.1                   - Doesn't say anything about org.gradle.plugin.api-version (required '8.3')

@MarcelBochtler MarcelBochtler requested a review from a team as a code owner September 20, 2023 09:48
@MarcelBochtler MarcelBochtler force-pushed the graphql-7.0.0-revert branch 2 times, most recently from 8c7f1a1 to 8f8907b Compare September 20, 2023 09:51
This reverts commit 0dfdaca, because
it breaks Java 11 compatibility, see [1].

[1]: https://github.com/ExpediaGroup/graphql-kotlin/releases/tag/7.0.0

Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
@sschuberth
Copy link
Member

Ah, yeah I was not reading this sentence from the release notes carefully enough:

With graphql-java finally moving to Java 11 target and Spring Boot v3 requiring Java 17, we also updated our compilation target to Java 17.

Really sad that we're stuck with Java 11 😢

@MarcelBochtler MarcelBochtler enabled auto-merge (rebase) September 20, 2023 11:07
@MarcelBochtler MarcelBochtler merged commit e40c142 into oss-review-toolkit:main Sep 20, 2023
19 checks passed
@MarcelBochtler MarcelBochtler deleted the graphql-7.0.0-revert branch September 20, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants