refactor(scanner,model): Move NestedProvenance to model #8724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the `NestedProvenance` data structure to model, allows it to be used within the model without creating a circular dependency between scanner and model. This would enable a future `AnalayzerInput` class [1] to utilize it and still be placed into the model, where its predecessor `Repostory` is already located. [1] oss-review-toolkit#2896 (comment) Signed-off-by: Jens Keim <jens.keim@forvia.com>
pepper-jk
force-pushed
the
nested-provenance-move
branch
from
51b9cb8 to
32a66e5
Compare
pepper-jk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8724 +/- ##
============================================
- Coverage 67.85% 67.82% -0.03%
+ Complexity 1165 1158 -7
============================================
Files 244 243 -1
Lines 7736 7726 -10
Branches 865 864 -1
============================================
- Hits 5249 5240 -9
+ Misses 2128 2127 -1
Partials 359 359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Closing this PR in favor of a different approach, see #2896 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the
NestedProvenancedata structure to model, allows it to be used within the model without creating a circular dependency between scanner and model.This would enable a future
AnalayzerInputclass [1] to utilize it and still be placed into the model,where its predecessor
Repostoryis already located.[1] #2896 (comment)
Signed-off-by: Jens Keim jens.keim@forvia.com