Make Npm separate from Yarn
#9393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
npm-rewrite
branch
4 times, most recently
from
be80da6 to
52ff169
Compare
The extraction of issues applies only to `Npm`, but not to `Yarn`. Extract it to a function and place it in `Npm` to reduce the diff of an upcoming change. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Prepare for removing the inheritance between these two. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9393 +/- ##
============================================
+ Coverage 67.91% 68.08% +0.16%
- Complexity 1262 1279 +17
============================================
Files 244 246 +2
Lines 8724 8814 +90
Branches 909 920 +11
============================================
+ Hits 5925 6001 +76
- Misses 2422 2428 +6
- Partials 377 385 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Analog to 0eb1eea, remove the inheritance between the two managers and re-write large parts of `Npm` to extract all needed information solely based on the output of the `npm` CLI command, instead of relying on the file hierarchy under the `node_modules` directory. This reduces complexity and makes the implementation(s) easy to understand, maintain and change in isolation. Note: The handling of the `installIssues` in `Yarn` has been used only for `Npm`, which is why that code is moved from `Yarn` to `Npm`. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The comments do not provide much information. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #9261.