llvm: upgrade to 18 #1439
Merged
llvm: upgrade to 18 #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes make it possible to build against llvm 18. In essence, there does not seem to be big problems. The only thing we need to adjust is how we identify indirect calls done by way of VTables. In essence we don't rely on types in function signatures from the LLVM IR anymore as we want to use debug information for this anyways, so we can kind of skip that part. Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
AdamKorcz
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting llvmorg-18-init-14420-gea3a3b25
Updates the core of fuzz introspector's LLVM frontend to support LLVM 18. Also adds updates needed to patch OSS-Fuzz to make it work with LLVM 18 and test introspector through OSS-Fuzz. However, the patches does certain things, e.g. avoids compiling centipede, avoids some things related to MSAN and more.
This has been tested against several OSS-Fuzz projects e.g.
htslib,leveldb,icu,tinyxml2,abseil-cpp,cxxopts. Interestingly,cxxoptsfailed compiling with FI previously but now succeeds, which is likely due to changes in the LLVM LTO linker logic.There are some changes in the calltrees, but, this is likely due to changes in the compiler. This patch does disable a feature of FI to walk the VTable for resolving indirect calls, but, it does not seem to have any real effect on the calltrees.