Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webapp: Fix wrong path for local inspector report path #1843

Closed

Conversation

arthurscchan
Copy link
Contributor

After the addition of light approach, the local $OUT/inspector directory has been moved to $OUT/inspector/inspector. This PR fixes the db building script to match the new directory structure for local FI build.

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
@arthurscchan arthurscchan marked this pull request as ready for review November 27, 2024 21:08
Copy link
Contributor

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, is this really the case? I don't see that. inspector/inspector can sometimes happen if project is build twice using introspector. This, however, shouldn't be the case following rsync in C/C++.

I believe you see this folder structure because a project is build twice and then the cp here will cause the double folder structure https://github.com/google/oss-fuzz/blob/92d61f8231c6075e0f9f555e1d2c7eb5dfecfa34/infra/base-images/base-builder/compile#L337

@arthurscchan
Copy link
Contributor Author

This PR is not needed any more after the fix in oss-fuzz compile infra script.

@arthurscchan arthurscchan deleted the fix-wrong-local-inspector-dir branch November 28, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants