-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable encoding of Maven registries. #231
Conversation
Fixes #208. Signed-off-by: Oliver Chang <ochang@google.com>
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Thanks @cuixq and @chrisbloom7 :) @darakian do you have any comments on this? Wanted to hear your thoughts also. |
@oliverchang, sorry for the delay. My only comment is that I think it's worth adding a fully formed example for an alternate registry. Using the first artifact I see on Otherwise, looks good to me 👍 |
Thanks! Hm, the group ID / artifact ID is not part of the ecosystem string here. It's instead part of the |
Signed-off-by: Oliver Chang <oliverchang@users.noreply.github.com>
Signed-off-by: Oliver Chang <ochang@google.com>
Fixes #208.