add Red Hat converter #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasinner
force-pushed
the
red-hat-csaf-converter
branch
2 times, most recently
from
695c5e4
to
0b4076e
Compare
andrewpollock
requested changes
Sep 10, 2024
jasinner
force-pushed
the
red-hat-csaf-converter
branch
from
0b4076e
to
de472eb
Compare
tools/redhat/osv.py
Outdated
| Also make sure to add a related entry for any GO advisory references found | ||
| """ | ||
| if reference["url"].startswith(ADVISORY_URL_PREFIXES): | ||
| self._add_go_related(reference["url"]) |
There was a problem hiding this comment.
This reads a bit awkwardly given it is called for non-Go advisories too.
Suggested change
| self._add_go_related(reference["url"]) | |
| self._maybe_add_go_related(reference["url"]) |
There was a problem hiding this comment.
Or maybe just pull out the conditional behaviour to the call site rather than inside the function?
There was a problem hiding this comment.
I removed this function and moved the code back in-line. I also renamed the calling function from get_reference_type to get_reference_type_and_add_go_related to better indicate it's dual behaviour.
Signed-off-by: Jason Shepherd <jshepher@redhat.com>
jasinner
force-pushed
the
red-hat-csaf-converter
branch
from
de472eb
to
7a30e2b
Compare
andrewpollock
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Red Hat CSAF to OSV converter tool used by Red Hat to produce the Red Hat OSV data to be hosted at https://security.access.redhat.com/data/osv
This is slightly modified version of the sample code originally review at https://github.com/andrewpollock/rhcsaf2osv