Add upstream field.
#312
Open
Add upstream field.
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #249. Signed-off-by: Oliver Chang <ochang@google.com>
This was referenced Nov 15, 2024
|
LGTM |
luhring
reviewed
Nov 19, 2024
docs/schema.md
Outdated
| @@ -518,7 +519,26 @@ package(s). For example, if a CVE describes a vulnerability in a language | |||
| library, and a Linux distribution package contains that library and therefore | |||
| publishes an advisory, the distribution's OSV record must not list the CVE ID as | |||
| an alias. Similarly, distributions often bundle multiple upstream | |||
| vulnerabilities into a single record. `related` should be used in these cases. | |||
| vulnerabilities into a single record. `upstream` should be used in these cases. | |||
There was a problem hiding this comment.
nit: I think it's slightly unclear what "these cases" refers to here, since this paragraph touches on both upstream and downstream packages.
There was a problem hiding this comment.
Thanks for the pointing this out. I've tweaked the wording here to make it clearer.
Co-authored-by: Dan Luhring <luhring@users.noreply.github.com> Signed-off-by: Oliver Chang <oliverchang@users.noreply.github.com>
Co-authored-by: Dan Luhring <luhring@users.noreply.github.com> Signed-off-by: Oliver Chang <oliverchang@users.noreply.github.com>
Signed-off-by: Oliver Chang <oliverchang@users.noreply.github.com>
|
Thanks for the suggestions @luhring ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249.