Rework of bucket path handling in resultstore.go #825
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to the
ResultStore
type to simplify bucket URL and path processing.The change is needed due to google/go-cloud#3294 which means special handling of file bucket URLs is required. Also fixes #811.
?no_tmp_files=true
to file bucket URLscmd/analyze/main.go
generatePath
function togenerateKey
which takes in the filename and prefixes it with the package info if theconstructPath
option is usedMakeFilename
function which was only used in two places and with different optionsMore unit tests should be added to test the bucket type used by the worker. This can be done in another PR before the next release.