Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the slogging changes. #874

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Complete the slogging changes. #874

merged 3 commits into from
Sep 11, 2023

Conversation

calebbrown
Copy link
Contributor

This PR wraps up the logging changes.

  • rename LabelAttr to Label now it is available again
  • remove zap from the tests
  • add a comment documenting why zap is still hanging around for the time being

Signed-off-by: Caleb Brown <calebbrown@google.com>
Signed-off-by: Caleb Brown <calebbrown@google.com>
Signed-off-by: Caleb Brown <calebbrown@google.com>
@calebbrown calebbrown merged commit 26117d7 into main Sep 11, 2023
9 checks passed
@calebbrown calebbrown deleted the logging_cleanups branch September 11, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants