Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: replace minus one score #236

Merged
merged 4 commits into from
Dec 16, 2023
Merged

Feature: replace minus one score #236

merged 4 commits into from
Dec 16, 2023

Conversation

KoolTheba
Copy link
Collaborator

@KoolTheba KoolTheba commented Dec 15, 2023 •
edited
Loading

Context

  • Replaced by no-available data question mark and tooltip with extra info when the api doesn't send score (-1) for an specific check, while removing increase-decrease badge.
  • Close Replace -1 for Question mark (?) #222
Captura de pantalla 2023-12-15 a las 19 24 47

Changelog

@KoolTheba KoolTheba added the enhancement New feature or request label Dec 15, 2023
UlisesGascon
UlisesGascon approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement. Thanks @KoolTheba!

@KoolTheba KoolTheba merged commit 6d3bd14 into main Dec 16, 2023
4 checks passed
@KoolTheba KoolTheba deleted the feature/replace-minus-one-score branch December 16, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace -1 for Question mark (?)
2 participants
@KoolTheba @UlisesGascon