Fixed code review comments.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
ossf · Dec 28, 2023 · 05166d0 · 05166d0
1 parent 44a85ae
commit 05166d0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pkg/json.go b/pkg/json.go
@@ -69,6 +69,8 @@ type jsonScorecardV2 struct {
 
 type jsonFloatScore float64
 
+var errNoDoc = errors.New("doc is nil")
+
 func (s jsonFloatScore) MarshalJSON() ([]byte, error) {
 	// Note: for integers, this will show as X.0.
 	return []byte(fmt.Sprintf("%.1f", s)), nil
@@ -148,7 +150,7 @@ func (r *ScorecardResult) AsJSON2(showDetails bool,
 			return sce.WithMessage(sce.ErrScorecardInternal, fmt.Sprintf("GetCheck: %s: %v", checkResult.Name, e))
 		}
 		if doc == nil {
-			return sce.WithMessage(sce.ErrScorecardInternal, fmt.Sprintf("GetCheck: %s: %v", checkResult.Name, errors.New("doc is nil")))
+			return sce.WithMessage(sce.ErrScorecardInternal, fmt.Sprintf("GetCheck: %s: %v", checkResult.Name, errNoDoc))
 		}
 
 		tmpResult := jsonCheckResultV2{

diff --git a/pkg/sarif_test.go b/pkg/sarif_test.go
@@ -872,7 +872,7 @@ func Test_createSARIFRuns(t *testing.T) {
 			want: []run{},
 		},
 		{
-			name: "test with nil run also",
+			name: "nil runs are skipped",
 			args: args{
 				runs: map[string]*run{
 					"run1": nil,