docs(branch-protection-check): adapt check description to consider re…

…quirement of require PRs to make changes It adds the new tier 2 requirement, but also specify that the "require at least 1 reviewer" will have doubled weight. Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
ossf · Sep 20, 2023 · 58d391a · 58d391a
1 parent 6a7853a
commit 58d391a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/docs/checks.md b/docs/checks.md
@@ -110,7 +110,8 @@ Tier 1 Requirements (3/10 points):
   - For administrators: Include administrator for review
 
 Tier 2 Requirements (6/10 points):
-  - Require at least 1 reviewer for approval before merging
+  - For administrators: Require PRs prior to make any code changes
+  - Require at least 1 reviewer for approval before merging (for administrators, this requirement weights twice than the others in this tier)
   - For administrators: Require branch to be up to date before merging
   - For administrators: Require approval of the most recent reviewable push
 

diff --git a/docs/checks/internal/checks.yaml b/docs/checks/internal/checks.yaml
@@ -199,7 +199,8 @@ checks:
         - For administrators: Include administrator for review
 
       Tier 2 Requirements (6/10 points):
-        - Require at least 1 reviewer for approval before merging
+        - For administrators: Require PRs prior to make any code changes
+        - Require at least 1 reviewer for approval before merging (for administrators, this requirement weights twice than the others in this tier)
         - For administrators: Require branch to be up to date before merging
         - For administrators: Require approval of the most recent reviewable push