Incomplete results logged as Info, not Warn

Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
ossf · Oct 24, 2023 · 6b6dba7 · 6b6dba7
1 parent 0971280
commit 6b6dba7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/checks/evaluation/pinned_dependencies.go b/checks/evaluation/pinned_dependencies.go
@@ -60,7 +60,7 @@ func PinningDependencies(name string, c *checker.CheckRequest,
 
 	for i := range r.Incomplete {
 		skipped := r.Incomplete[i]
-		dl.Warn(&checker.LogMessage{
+		dl.Info(&checker.LogMessage{
 			Text: generateTextIncompleteResults(skipped),
 			Type: finding.FileTypeSource,
 		})

diff --git a/checks/evaluation/pinned_dependencies_test.go b/checks/evaluation/pinned_dependencies_test.go
@@ -287,8 +287,8 @@ func Test_PinningDependencies(t *testing.T) {
 			expected: scut.TestReturn{
 				Error:         nil,
 				Score:         8,
-				NumberOfWarn:  3, // 2 for npm commands, 1 for skipped job
-				NumberOfInfo:  7,
+				NumberOfWarn:  2,
+				NumberOfInfo:  8, // 7 for all but npm, +1 for skipped job
 				NumberOfDebug: 0,
 			},
 		},