Adjustments after review

Signed-off-by: Felix Hoeborn <f.hoeborn@gmail.com>
ossf · Apr 1, 2024 · 77bbceb · 77bbceb
1 parent 166c26b
commit 77bbceb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/probes/hasPermissiveLicense/def.yml b/probes/hasPermissiveLicense/def.yml
@@ -20,7 +20,7 @@ implementation: >
  The implementation checks whether a permissive license is present
 outcome:
   - If a license file is found and is permissive, the probe returns a single OutcomePositive.
-  - If a license file is missing the probe returns a single OutcomeNotApplicable.
+  - If a license file is missing the probe returns a single OutcomeNegative.
   - If the license is not permissive, the probe returns a single OutcomeNegative.
 remediation:
   effort: High

diff --git a/probes/hasPermissiveLicense/impl.go b/probes/hasPermissiveLicense/impl.go
@@ -34,10 +34,10 @@ func Run(raw *checker.RawResults) ([]finding.Finding, string, error) {
 		return nil, "", fmt.Errorf("%w: raw", uerror.ErrNil)
 	}
 
-	if raw.LicenseResults.LicenseFiles == nil || len(raw.LicenseResults.LicenseFiles) == 0 {
+	if len(raw.LicenseResults.LicenseFiles) == 0 {
 		f, err := finding.NewWith(fs, Probe,
 			"project does not have a license file", nil,
-			finding.OutcomeNotApplicable)
+			finding.OutcomeNegative)
 		if err != nil {
 			return nil, Probe, fmt.Errorf("create finding: %w", err)
 		}

diff --git a/probes/hasPermissiveLicense/impl_test.go b/probes/hasPermissiveLicense/impl_test.go
@@ -83,7 +83,7 @@ func Test_Run(t *testing.T) {
 				},
 			},
 			outcomes: []finding.Outcome{
-				finding.OutcomeNotApplicable,
+				finding.OutcomeNegative,
 			},
 		},
 		{
@@ -94,7 +94,7 @@ func Test_Run(t *testing.T) {
 				},
 			},
 			outcomes: []finding.Outcome{
-				finding.OutcomeNotApplicable,
+				finding.OutcomeNegative,
 			},
 		},
 		{
@@ -105,7 +105,7 @@ func Test_Run(t *testing.T) {
 				},
 			},
 			outcomes: []finding.Outcome{
-				finding.OutcomeNotApplicable,
+				finding.OutcomeNegative,
 			},
 		},
 	}