fix dangerous workflow test

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
ossf · Apr 21, 2023 · cc89464 · cc89464
1 parent 8f00884
commit cc89464
Showing 1 changed file with 20 additions and 1 deletion.
diff --git a/checks/evaluation/dangerous_workflow_test.go b/checks/evaluation/dangerous_workflow_test.go
@@ -43,7 +43,23 @@ func TestDangerousWorkflow(t *testing.T) {
 				r:    &checker.DangerousWorkflowData{},
 			},
 			want: checker.CheckResult{
-				Score:   10,
+				Score:   checker.InconclusiveResultScore,
+				Reason:  "no workflows found",
+				Version: 2,
+				Name:    "DangerousWorkflow",
+			},
+		},
+		{
+			name: "DangerousWorkflow - found workflows, none dangerous",
+			args: args{
+				name: "DangerousWorkflow",
+				dl:   &scut.TestDetailLogger{},
+				r: &checker.DangerousWorkflowData{
+					NumWorkflows: 5,
+				},
+			},
+			want: checker.CheckResult{
+				Score:   checker.MaxResultScore,
 				Reason:  "no dangerous workflow patterns detected",
 				Version: 2,
 				Name:    "DangerousWorkflow",
@@ -55,6 +71,7 @@ func TestDangerousWorkflow(t *testing.T) {
 				name: "DangerousWorkflow",
 				dl:   &scut.TestDetailLogger{},
 				r: &checker.DangerousWorkflowData{
+					NumWorkflows: 1,
 					Workflows: []checker.DangerousWorkflow{
 						{
 							Type: checker.DangerousWorkflowUntrustedCheckout,
@@ -82,6 +99,7 @@ func TestDangerousWorkflow(t *testing.T) {
 				name: "DangerousWorkflow",
 				dl:   &scut.TestDetailLogger{},
 				r: &checker.DangerousWorkflowData{
+					NumWorkflows: 1,
 					Workflows: []checker.DangerousWorkflow{
 						{
 							Type: checker.DangerousWorkflowScriptInjection,
@@ -109,6 +127,7 @@ func TestDangerousWorkflow(t *testing.T) {
 				name: "DangerousWorkflow",
 				dl:   &scut.TestDetailLogger{},
 				r: &checker.DangerousWorkflowData{
+					NumWorkflows: 1,
 					Workflows: []checker.DangerousWorkflow{
 						{
 							Type: "foobar",