semantic version (#991)

cmd/version.go

@@ -33,7 +33,7 @@ var versionCmd = &cobra.Command{
 	Long:  ``,
 	Run: func(cmd *cobra.Command, args []string) {
 		// not using logger, since it prints timing info, etc
-		fmt.Printf("GitVersion:\t%s\n", pkg.GetVersion())
+		fmt.Printf("GitVersion:\t%s\n", pkg.GetTagVersion())
 		fmt.Printf("GitCommit:\t%s\n", pkg.GetCommit())
 		fmt.Printf("GitTreeState:\t%s\n", pkg.GetTreeState())
 		fmt.Printf("BuildDate:\t%s\n", pkg.GetBuildDate())

pkg/sarif.go

@@ -58,7 +58,6 @@ type physicalLocation struct {
 	ArtifactLocation artifactLocation `json:"artifactLocation"`
 }
 
-//TODO: remove linter and update unit tests.
 //nolint:govet
 type location struct {
 	PhysicalLocation physicalLocation `json:"physicalLocation"`

pkg/scorecard.go

@@ -101,7 +101,7 @@ func RunScorecards(ctx context.Context,
 			CommitSHA: commitSHA,
 		},
 		Scorecard: ScorecardInfo{
-			Version:   GetVersion(),
+			Version:   GetSemanticVersion(),
 			CommitSHA: GetCommit(),
 		},
 		Date: time.Now(),

pkg/scorecard_version.go

@@ -16,6 +16,7 @@ package pkg
 
 import (
 	"runtime"
+	"strings"
 )
 
 // Base version information.
@@ -34,11 +35,22 @@ var (
 	buildDate = "unknown"
 )
 
-// GetVersion returns the scorecard version.
-func GetVersion() string {
+// GetTagVersion returns the scorecard version
+// fr the release GitHub tag, i.e. v.X.Y.Z.
+func GetTagVersion() string {
 	return gitVersion
 }
 
+// GetSemanticVersion returns the semantic version,
+// i.e., X.Y.Z.
+func GetSemanticVersion() string {
+	tv := GetTagVersion()
+	if strings.HasPrefix(tv, "v") {
+		return tv[1:]
+	}
+	return tv
+}
+
 // GetCommit returns the GitHub's commit hash that scorecard was built from.
 func GetCommit() string {
 	return gitCommit