-
Notifications
You must be signed in to change notification settings - Fork 474
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🌱 Cleanup codeApproved outcomes and semantics (#3902)
* tidy probe documentation Signed-off-by: Spencer Schrock <sschrock@google.com> * export probe name Signed-off-by: Spencer Schrock <sschrock@google.com> * check for no raw data Signed-off-by: Spencer Schrock <sschrock@google.com> * return OutcomeNotApplicable when no changesets are present Signed-off-by: Spencer Schrock <sschrock@google.com> * extract approved logic and return errors as OutcomeError Signed-off-by: Spencer Schrock <sschrock@google.com> * simplify finding creation Signed-off-by: Spencer Schrock <sschrock@google.com> * add clarifying comment for skipping bot changes Signed-off-by: Spencer Schrock <sschrock@google.com> * only bot commits results in OutcomeNotApplicable Signed-off-by: Spencer Schrock <sschrock@google.com> * move no changeset code back to where it was originally Signed-off-by: Spencer Schrock <sschrock@google.com> * include ratio of approved/total as values count the number of approved vs unapproved changesets Signed-off-by: Spencer Schrock <sschrock@google.com> * ensure unreviewed bot PRs always give negative outcome Signed-off-by: Spencer Schrock <sschrock@google.com> * use common outcome test code Signed-off-by: Spencer Schrock <sschrock@google.com> * fix linter Signed-off-by: Spencer Schrock <sschrock@google.com> * mention dependabot in probe description Signed-off-by: Spencer Schrock <sschrock@google.com> --------- Signed-off-by: Spencer Schrock <sschrock@google.com>
- Loading branch information
1 parent
16b6759
commit e9af90c
Showing
3 changed files
with
138 additions
and
114 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.