-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitLab job/pipeline don't have conclusion fields #3396
Comments
This issue is stale because it has been open for 60 days with no activity. |
GItlabs Not sure if this issue requires more high level discussion, but I'm happy to take a whack at it |
SAST also checks the conclusion: Line 45 in 76878e5
Lines 101 to 103 in 76878e5
We generally like to put all data in the raw results, and let the evaluation code handle the judging. Is there a reason to not do this for GitLab? |
No reason, really. My thought was to use calls we're already making to get more info about the pipelines to help decide what goes in the conclusion and status fields for gitlab pipelines. Let me try to explain what I meant a bit better:
I get wanting to pull everything and let the code filter through it as needed (we may look at non-completed pipelines at some point). Just wanted to gauge preferences on this before proposing changes. Parsing the GItlab Status and inferring the conclusion and Status fields would also work. |
GitHub worksflows have two fields,
Status
andConclusion
, which is what we built into our model.GitLab, just has a
Status
. I think we can parse the status field to setstatus
andconclusion
to their GitHub equivalent, or we can adjust the model going forward to be more generic. We may not have an answer immediately.This seems to affect the
CI-Tests
andSAST
checks.The text was updated successfully, but these errors were encountered: