🐛 Parse Gitlab Status fields to align w/Github Status and Conclusion #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashearin
requested review from
spencerschrock and
laurentsimon
and removed request for
a team
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3706 +/- ##
==========================================
- Coverage 76.31% 70.78% -5.53%
==========================================
Files 210 210
Lines 14371 14397 +26
==========================================
- Hits 10967 10191 -776
- Misses 2757 3614 +857
+ Partials 647 592 -55 |
ashearin
force-pushed
the
gitlab-conclusion-fields
branch
from
c849068
to
c28bf22
Compare
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
force-pushed
the
gitlab-conclusion-fields
branch
from
c28bf22
to
eb6ffe5
Compare
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
approved these changes
Dec 1, 2023
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
* Trust pinned GitHub download URLs Trust files that are downloaded from `raw.githubusercontent.com` where the file's ref is a Git SHA and therefore immutable. Resolves ossf#3339. Signed-off-by: martincostello <martin@martincostello.com> * Move logic to function - Add `hasUnpinnedURLs` function. - Add test cases for different URLs. Signed-off-by: martincostello <martin@martincostello.com> * Fix formatting Appease the linter. Signed-off-by: martincostello <martin@martincostello.com> * Suppress lint warnings Suppress warning on three long URLs. Signed-off-by: martincostello <martin@martincostello.com> * Address peer review Address peer review feedback. Signed-off-by: martincostello <martin@martincostello.com> * Fix lint warning Fix lint warning. Signed-off-by: martincostello <martin@martincostello.com> Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.16.1 to 0.17.0. - [Release notes](https://github.com/google/go-containerregistry/releases) - [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml) - [Commits](google/go-containerregistry@v0.16.1...v0.17.0) --- updated-dependencies: - dependency-name: github.com/google/go-containerregistry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
ashearin
force-pushed
the
gitlab-conclusion-fields
branch
from
d04c9a3
to
7632aa9
Compare
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Introduces code to parse status returned from gitlab to align with github status and conclusion fields
What is the current behavior?
When populating checkruns from Gitlab commits, we currently assign the gitlab status to the checkrun status and leave the conclusion blank (Since gitlab does not have an equivalent field, the gitlab status field is roughly a combination of the github status and conclusion fields)
What is the new behavior (if this is a feature change)?**
Added a function to parse the gitlab status into the appropriate github equivalent status and conclusion. In most cases the Conclusion is still empty (since the pipeline is not completed), but the status will match the equivalent Github status.
References:
GItlab Status Enum
Github CheckRun Docs
Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
Fixes #3396
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)