Cleanup old error names before full v5 release

[spencerschrock]

We have a few linter exceptions around old errors which don't follow the naming conventions enabled in #3587.

It would be good to take care of the //nolint:errname directives while we're doing breaking changes.

scorecard/errors/public.go

Lines 31 to 41 in 0b9dfb6

	ErrorUnsupportedHost = errors.New("unsupported host") //nolint:errname
	// ErrorInvalidURL indicates the repo's full URL was not passed.
	ErrorInvalidURL = errors.New("invalid repo flag") //nolint:errname
	// ErrorShellParsing indicates there was an error when parsing shell code.
	ErrorShellParsing = errors.New("error parsing shell code") //nolint:errname
	// ErrJobOSParsing indicates there was an error when detecting a job's operating system.
	ErrJobOSParsing = errors.New("error parsing job operating system")
	// ErrorUnsupportedCheck indicates check cannot be run for given request.
	ErrorUnsupportedCheck = errors.New("check is not supported for this request") //nolint:errname
	// ErrorCheckRuntime indicates an individual check had a runtime error.
	ErrorCheckRuntime = errors.New("check runtime error") //nolint:errname

scorecard/cron/config/config.go

Lines 61 to 70 in 0b9dfb6

	var (
	// some of these errors didn't follow naming conventions when they were introduced.
	// for backward compatibility reasons, they can't be changed and have nolint directives.
	// ErrorEmptyConfigValue indicates the value for the configuration option was empty.
	ErrorEmptyConfigValue = errors.New("config value set to empty") //nolint:errname
	// ErrorValueConversion indicates an unexpected type was found for the value of the config option.
	ErrorValueConversion = errors.New("unexpected type, cannot convert value") //nolint:errname
	// ErrorNoConfig indicates no config file was provided, or flag.Parse() was not called.
	ErrorNoConfig = errors.New("no configuration file provided with --" + configFlag) //nolint:errname

[cmwylie19]

can you please assign this to me? (i'm at SOSS day at OpenSSF)

[laurentsimon]

@cmwylie19 the issue is assigned to you. Welcome!