Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ errors in ErrXXX format #4040

Merged
merged 1 commit into from
Apr 18, 2024
Merged

⚠️ errors in ErrXXX format #4040

merged 1 commit into from
Apr 18, 2024

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Apr 17, 2024

What kind of change does this PR introduce?

fix linting expections around errors

FIX Took care of the //nolint:errname directives while we're doing breaking changes.

What is the current behavior?

uses directive to skip lint

What is the new behavior (if this is a feature change)?**

does not skip lint, fixed the errors

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #4033

Special notes for your reviewer

From OSSNA workshop

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19 cmwylie19 requested a review from a team as a code owner April 17, 2024 19:00
@cmwylie19 cmwylie19 requested review from naveensrinivasan and spencerschrock and removed request for a team April 17, 2024 19:00
@cmwylie19 cmwylie19 temporarily deployed to integration-test April 17, 2024 21:10 — with GitHub Actions Inactive
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmwylie19 Thank you for the contribution!

@naveensrinivasan
Copy link
Member

@spencerschrock 👀

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for swinging by the workshop and contributing! I'm going to make a small tweak to the title since this is a breaking change, but otherwise LGTM!

@spencerschrock spencerschrock changed the title 🐛 : errors in ErrXXX format ⚠️ errors in ErrXXX format Apr 18, 2024
@spencerschrock spencerschrock merged commit 39e968d into ossf:main Apr 18, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cleanup old error names before full v5 release
3 participants