Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Move docker build checks to ko #1214

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Conversation

naveensrinivasan
Copy link
Member

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    Move the docker builds checks to ko. Part of moving to Feature: Use google/ko instead of Dockerfile #744

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

None

  • Other information:

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Integration tests failure for 861ff865f93fec7c88070e5bcc36733340266151

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Integration tests failure for 95a662aa6dda8d7842e34e10cbff9cda27c04e28

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Integration tests success for 5b921704f37166c1b20ab6b0ad8a11c3a838a863

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Integration tests success for 462930effc75cac4d3d943476641d5c81cbcc22a

.github/workflows/integration.yml Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 7, 2021

Integration tests success for ea3c5ea9788893dbb8919c5e7300a622addf6d75

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

Integration tests success for 84199e608e101f09824863a27ec93765c2d484cc

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makefile Outdated Show resolved Hide resolved
Move the docker builds checks to ko
@naveensrinivasan naveensrinivasan enabled auto-merge (squash) November 8, 2021 15:33
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Integration tests success for 5350611d1f5541c564b06c69e59e2dd74fe35869

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Integration tests success for ec92147505919f30161f0f9845355da4d67261a2

@naveensrinivasan naveensrinivasan merged commit 4ee366e into main Nov 8, 2021
@naveensrinivasan naveensrinivasan deleted the naveen/feat/ko-builds branch November 8, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants