Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Updated the community links #1216

Merged
merged 2 commits into from
Nov 4, 2021
Merged

📖 Updated the community links #1216

merged 2 commits into from
Nov 4, 2021

Conversation

naveensrinivasan
Copy link
Member

  • Please check if the PR fulfills these requirements

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

    Updated the community links to be more accessible. Took the idea from https://github.com/tektoncd/community/blob/main/working-groups.md#chains

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@naveensrinivasan naveensrinivasan self-assigned this Nov 4, 2021
@naveensrinivasan naveensrinivasan changed the title :docs: Updated the community links 📖 Updated the community links Nov 4, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Integration tests success for c781e8d4dfba2bc1e7af3faff8522ec1b7d6d075

azeemshaikh38
azeemshaikh38 approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will leave it to @olivekl for the final approval.

@naveensrinivasan
Copy link
Member Author

LGTM. Will leave it to @olivekl for the final approval.

Thanks!

@naveensrinivasan
Copy link
Member Author

@laurentsimon I included your name in this. I completely forgot to get your approval. Can you please review it?

laurentsimon
laurentsimon reviewed Nov 4, 2021
View reviewed changes
README.md Outdated
| -------------------------- | -------------------------- |
| Scorecard Dev Forum | [ossf-scorecard-dev@](https://groups.google.com/g/ossf-scorecard-dev) |
| Scorecard Announcements Forum | [ossf-scorecard-announce@](https://groups.google.com/g/ossf-scorecard-announce) |
| Community Meeting VC | [https://zoom.us/j/98835923979](https://zoom.us/j/98835923979) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it standard to provide easy-to-crawl/parse meeting links this way? No fear of zoom-bombing or the like? I don't think we can do anything about it, but if you come across a solution, let's use it in the future

laurentsimon
laurentsimon approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@olivekl
Copy link
Contributor

olivekl commented Nov 4, 2021

My only concern would be including the Zoom link, which Laurent mentioned as well. Otherwise, everything LGTM. Thanks for these improvements!

@naveensrinivasan
Copy link
Member Author

My only concern would be including the Zoom link, which Laurent mentioned as well. Otherwise, everything LGTM. Thanks for these improvements!

I updated the Zoom link title not to have the actual link. Thanks

@naveensrinivasan naveensrinivasan enabled auto-merge (squash) November 4, 2021 16:40
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Integration tests success for c53c6768e8ec9ced66909905f3c2d4e73d3ad7c2

@naveensrinivasan naveensrinivasan merged commit ddd770a into main Nov 4, 2021
@naveensrinivasan naveensrinivasan deleted the naveensrinivasan/community/docs branch November 4, 2021 16:59
@laurentsimon
Copy link
Contributor

My only concern would be including the Zoom link, which Laurent mentioned as well. Otherwise, everything LGTM. Thanks for these improvements!

I updated the Zoom link title not to have the actual link. Thanks

Maybe we could say "See calendar invite below"

@spencerschrock spencerschrock mentioned this pull request Dec 18, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeemshaikh38 azeemshaikh38 azeemshaikh38 approved these changes

@laurentsimon laurentsimon laurentsimon approved these changes

@olivekl olivekl Awaiting requested review from olivekl

Assignees

@naveensrinivasan naveensrinivasan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@naveensrinivasan @olivekl @laurentsimon @azeemshaikh38