🐛 Fix nil-ptr access bug #1248
Merged
🐛 Fix nil-ptr access bug #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
approved these changes
Nov 12, 2021
|
Integration tests success for 63a68dc24d891e0733af23cc13fa7297c2c98432 |
azeemshaikh38
force-pushed
the
azeems/nilptr
branch
from
63a68dc
to
af68291
Compare
azeemshaikh38
force-pushed
the
azeems/nilptr
branch
from
af68291
to
f763fb4
Compare
|
Integration tests failure for af68291c665e5ec5d8ae0c807bd9c60e8c57f165 |
|
Integration tests failure for f763fb439a52102ce23c182b2b6418b0e5e0b5b0 |
azeemshaikh38
force-pushed
the
azeems/nilptr
branch
from
4a405a8
to
8c8d4de
Compare
|
Integration tests failure for 4a405a848818e626ea3a9f0e4bd2774e05a9e041 |
|
Integration tests failure for 8c8d4de5b26c3114fd1a12a1535eb5074886202c |
azeemshaikh38
force-pushed
the
azeems/nilptr
branch
from
8c8d4de
to
04955c6
Compare
|
Integration tests success for 04955c6e852477f9527b9356b5011c8861d27495 |
|
@azeemshaikh38 Thanks for taking care of this. And good idea to make the helper functions to do the nil checking in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Nil-ptr access bug.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.