Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Discard GitHub token in dangerous workflow check #1772

Merged
merged 4 commits into from
Mar 23, 2022

Conversation

laurentsimon
Copy link
Contributor

Don't alert if the default GH token is used on pull requests. See #1770
No breaking changes

Don't alert if the default GH token is used on pull requests

closes #1770

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #1772 (96a9790) into main (66b3d8c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1772   +/-   ##
=======================================
  Coverage   56.71%   56.72%           
=======================================
  Files          65       65           
  Lines        6377     6378    +1     
=======================================
+ Hits         3617     3618    +1     
  Misses       2519     2519           
  Partials      241      241           

@laurentsimon laurentsimon temporarily deployed to integration-test March 22, 2022 23:39 Inactive
@github-actions
Copy link

Integration tests success for
[7d359c6]
(https://github.com/ossf/scorecard/actions/runs/2025417709)

@github-actions
Copy link

Integration tests success for
[79c4923]
(https://github.com/ossf/scorecard/actions/runs/2025419294)

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was also thinking of the same. Cool!

@laurentsimon
Copy link
Contributor Author

All my PRs are failing with:

protoc --go_out=../../../ cron/data/request.proto
/bin/bash: protoc: command not found
make: *** [Makefile:10[8](https://github.com/ossf/scorecard/runs/5652653919?check_suite_focus=true#step:7:8): cron/data/request.pb.go] Error 127

@laurentsimon laurentsimon enabled auto-merge (squash) March 23, 2022 01:14
@laurentsimon laurentsimon temporarily deployed to integration-test March 23, 2022 01:26 Inactive
@github-actions
Copy link

Integration tests success for
[83337c5]
(https://github.com/ossf/scorecard/actions/runs/2025778239)

@laurentsimon
Copy link
Contributor Author

@naveensrinivasan @azeemsgoogle any ideas why PRs are suddenly all failing with protobuf errors?

@naveensrinivasan
Copy link
Member

@naveensrinivasan @azeemsgoogle any ideas why PRs are suddenly all failing with protobuf errors?

I am tired of fixing it TBH. We need to find a way to retry it or do something about this.

@laurentsimon laurentsimon temporarily deployed to integration-test March 23, 2022 23:32 Inactive
@github-actions
Copy link

Integration tests success for
[96a9790]
(https://github.com/ossf/scorecard/actions/runs/2031333187)

@laurentsimon laurentsimon merged commit 2bbbce7 into ossf:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: don't warn if default GH token is used in pull request
2 participants