Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix remediation code #1947

Merged
merged 2 commits into from
May 23, 2022
Merged

🐛 Fix remediation code #1947

merged 2 commits into from
May 23, 2022

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented May 23, 2022

Fix remediation code. The if statement was incorrect: we were not returning in case there was an error. b was nil in this case and caused a nil pointer.

Fix remediation code

closes #1942

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this fixes the nil-ptr dereference, but code LG to submit. For the sake of posterity, could you explain in the PR description why this was causing code to panic?

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1947 (e8b6d3b) into main (1a2f088) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1947      +/-   ##
==========================================
- Coverage   50.30%   50.29%   -0.01%     
==========================================
  Files          83       83              
  Lines        6900     6901       +1     
==========================================
  Hits         3471     3471              
- Misses       3198     3199       +1     
  Partials      231      231              

@laurentsimon
Copy link
Contributor Author

Not sure how this fixes the nil-ptr dereference, but code LG to submit. For the sake of posterity, could you explain in the PR description why this was causing code to panic?

Done in PR description.

@laurentsimon laurentsimon enabled auto-merge (squash) May 23, 2022 21:05
@laurentsimon laurentsimon temporarily deployed to integration-test May 23, 2022 21:05 Inactive
@github-actions
Copy link

Integration tests success for
[e8b6d3b]
(https://github.com/ossf/scorecard/actions/runs/2373936555)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: nil-ptr dereference
2 participants